pgkos added a comment.

  In my opinion, roundToIconSize should operate on scaled units - it is used 
multiple times in a few plasmoids - all calls from them to roundToIconSize 
assume it will operate on scaled units.
  
  The method, as it is now, is useless, because QML code has no access to 
KIconLoader sizes and devicePixelIconSize() method, so it cannot operate on 
unscaled units or convert them on the fly.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D7849

To: pgkos, #plasma
Cc: ngraham, anthonyfieroni, broulik, #frameworks, davidedmundson, 
plasma-devel, michaelh, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Reply via email to