broulik created this revision. broulik added reviewers: Plasma, graesslin. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision.
REVISION SUMMARY The delegate is quite heavy with lots of seldom used items and opening the clipboard plasmoid takes a significant amount of time. TEST PLAN - Plasmoid opens almost instantly now - Verified that single line and multi line text still shows properly - Verified that delegate height is correct in all cases (initially, multi line text, with tool buttons shown, image, list) - Unchecked "ignore images", copied image, delegate was shown correctly - Copied a couple of files, they showed up correctly, both when there's enough room and when it overflows "+n files" - Verified that clicking a delegate item copies it to clipboard and moves it to the top - Removing items from history still works - Generating barcode still works - Configured an action, copied some text with it in, clicked "run action" button, popup to choose action showed up and action could be triggered - Verified that tool buttons are created only on hover and only once - Verified that the fancy gradient is rendered correctly in both LTR and RTL mode REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10557 AFFECTED FILES applets/clipboard/contents/ui/ClipboardItemDelegate.qml applets/clipboard/contents/ui/DelegateToolButtons.qml applets/clipboard/contents/ui/ImageItemDelegate.qml applets/clipboard/contents/ui/TextItemDelegate.qml applets/clipboard/contents/ui/UrlItemDelegate.qml To: broulik, #plasma, graesslin Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
