ngraham created this revision. ngraham added reviewers: Plasma, Kirigami, mart. Restricted Application added projects: Plasma, Kirigami. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision.
REVISION SUMMARY BUG: 384638 FIXED-IN: KDE Plasma 5.12.2 System Settings' sidebar headers were implemented as orginary Kirigami list items that had `enabled: false` set, which made them turn an almost unreadable light color. This was the wrong hack. This patch changes the hack to a different one that works much better. Ideally we would use real Kirigami list headers here, but the current system settings implementation seems to make this a challenge and I'm not sure it's worth it. TEST PLAN Before: After, Breeze light: After, Breeze dark: REPOSITORY R124 System Settings BRANCH more-visible-headers (branched from master) REVISION DETAIL https://phabricator.kde.org/D10620 AFFECTED FILES sidebar/package/contents/ui/CategoriesPage.qml To: ngraham, #plasma, #kirigami, mart Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, davidedmundson, mart, hein