davidedmundson requested changes to this revision. davidedmundson added inline comments. This revision now requires changes to proceed.
INLINE COMMENTS > mart wrote in svgitem.cpp:50 > when the component is complete, in many cases i guessthe properties would all > be already set? (could add a check on that) could even be worth directly a > loadPixmap, like an immediate updatePolish() there > when the component is complete, in many cases i guessthe properties would all > be already set? We know for definitely they will be already set. I don't understand what problem you think this is solving. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10722 To: mart, #plasma, davidedmundson Cc: davidedmundson, broulik, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
