arfrever added inline comments.

INLINE COMMENTS

> CMakeLists.txt:97
> +if ( NOT HAVE_LOGINCTL )
> +    find_package(ConsoleKit)
> +    set_package_properties(ConsoleKit PROPERTIES

I would suggest that this build-time detection of ConsoleKit occur always, and 
as a result, that ck-unlock-session be always installed if ConsoleKit is 
installed.
For example, I have both loginctl and ConsoleKit installed, but loginctl is not 
running and ConsoleKit is running.
(loginctl is part of systemd whose library functionality can be used by other 
packages even when systemd is not used as init system.)

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D9713

To: tcberner, graesslin, #freebsd, #plasma
Cc: arfrever, broulik, PureTryOut, adridg, pprkut, graesslin, plasma-devel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Reply via email to