kossebau marked an inline comment as done.
kossebau added inline comments.

INLINE COMMENTS

> broulik wrote in ContextMenu.qml:169
> In the media controller you do status == "playing" || status == "paused" 
> whereas here you do status == "stopped"?

Yes, in the media controller the status is going for the applet qml state 
strings, given those are also used around. So there it is for consistency with 
rest of media controller code.

Here there is no QML state, so I used the mpris property state directly with 
shortest logic. Torn by two consistency attractors. Make a call, please :)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11007

To: kossebau, broulik
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

Reply via email to