Pitel updated this revision to Diff 29690.
Pitel added a comment.

  @mart you were very right to point out the `callLater` because that is 
exactly what was broken. The code assumed that all calls of `callLater` with 
different arguments are executed but in fact only those eith different function 
are, rest of arguments does not matter. I somehow managed to run an older 
version of patch on my machine were `callLater` was applied to local helper 
function so it worked for me...
  
  - Removed `callLater` stuff and also removed the `onParentChanged` hook (not 
sure why it was needed in the first place...)
  - Renamed `getCategoryOrder` to `indexForItemCategory` and `itemCompare` to 
`compareItems`.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11352?vs=29592&id=29690

BRANCH
  stableSystray2

REVISION DETAIL
  https://phabricator.kde.org/D11352

AFFECTED FILES
  applets/systemtray/package/contents/ui/items/AbstractItem.qml
  applets/systemtray/package/contents/ui/main.qml

To: Pitel
Cc: wsdfhjxc, mart, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

Reply via email to