progwolff planned changes to this revision. progwolff added a comment.
In D11289#229340 <https://phabricator.kde.org/D11289#229340>, @mart wrote: > can you provide screenshots as well t see how does it look? I added one under "test plan". INLINE COMMENTS > mart wrote in FormLayout.qml:213 > should the behavior of the shortcut change to toggle the checkbox instead > when the item is checkable? Good idea! > mart wrote in FormLayout.qml:226 > What's this rectangle about? It highlights the label when the checkbox is in focus. You can see it in the new screenshot under "test plan". This part is stolen from PlasmaComponents: https://api.kde.org/frameworks/plasma-framework/html/CheckBoxStyle_8qml_source.html line 30 > mart wrote in formlayoutattached.h:110 > api wise an "enabled" property doesn't have anything to do with checkboxes It has nothing to do with checkboxes in particular. Here it is used as a combined `enabled` for the buddy component. How would you call it? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D11289 To: progwolff, #vdg, #kirigami Cc: mart, ngraham, plasma-devel, apol, davidedmundson, hein
