Pitel updated this revision to Diff 29940. Pitel added a comment.
In D11410#229277 <https://phabricator.kde.org/D11410#229277>, @mart wrote: > it's moving on the right track.. i would like the checkbox to appear like the one in the panel spacer, in the context menu could be tricky as would need to inject into the applet's contextualactons, so let's forget about it for now. I'm not sure that is good idea: There are already some items injected in context menus (e.g. Unlock widgets action) and looking at my panel some applets' context menus are not injected. I believe it is because they have multiple menus bound to specific parts of itself and only applet's global menu is (and can) be injected. Most notable examples are systray except the expansion arrow and task icon manager except empty space (if it has set `fixedWidth` I was unable to find a place in it which would show me context menu containing Unlock widget action). > one thing that could be done is to put that button in the applet handle that appears on hover when the panel controller is open, with the same icon of the add panel spacer in a checkable toolbutton (just icon, tooltip on hover) the panel spacer should use the same config ui. The combox is currently in the popup showing on hover when panel controller is open. I can make it replace spacer's specific option. I can just remove spacer's option from its context menu and add some temporary code to convert spacer's option into the new one. (And a few version later we can drop this code.) Is it what you meant or did I misunderstand you? > i would like to expose this ui only for applets that want to expand, and not for those that are already compact (i don't think this option would make any sense in kicoff for instance) Done. Changes: - Fix config item label - Show checkbox only for expanding applets - A bit polish checkbox placement REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11410?vs=29745&id=29940 BRANCH fixedSizeOverride REVISION DETAIL https://phabricator.kde.org/D11410 AFFECTED FILES containments/panel/contents/config/main.xml containments/panel/contents/ui/ConfigOverlay.qml containments/panel/contents/ui/main.qml To: Pitel, #plasma Cc: mart, hein, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
