fredrik added a comment.
In D10750#224860 <https://phabricator.kde.org/D10750#224860>, @romangg wrote: > In D10750#216337 <https://phabricator.kde.org/D10750#216337>, @fredrik wrote: > > > An issue that this patch does not fully address is switching compositing backends at runtime. > > > Do we support that at all? The backend is set at startup. Don't think you can change this later on. That is the question I'm asking. INLINE COMMENTS > romangg wrote in abstract_egl_backend.h:100 > Why QLinkedList? It should be no better than QList for the removeOne call. > For this better use QSet. I believe the use of QList is discouraged in new code, but you are right about QSet being a better choice in this case. > romangg wrote in abstract_egl_backend.h:135 > Why is it necessary to export? I guess it isn't. I was thinking at the time that someone might want to use this class in a class derived from AbstractEglBackend or AbstractEglTexture. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D10750 To: fredrik, #kwin, #plasma, davidedmundson, mart, graesslin Cc: romangg, anthonyfieroni, plasma-devel, kwin, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
