broulik added inline comments.

INLINE COMMENTS

> breezewindowmanager.cpp:100
> +#if QT_VERSION >= QT_VERSION_CHECK(5, 11, 0)
> +#include <qpa/qplatformwindow.h>
>  #endif

Using private API will lock Breeze to that specific Qt version it was compiled 
with, requiring a rebuild. This has imho shown to be quite painful in 
plasma-integration and Kwin already.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11573

To: volkov, #breeze
Cc: broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

Reply via email to