broulik added inline comments.
INLINE COMMENTS
> maps.h:116
> + int modelIndex = 0;
> + const auto keys = m_data.keys();
> + for (quint32 key : keys) {
This creates a temporary list just to iterate it, better use iterators and then
`key()` provided by it (I bet there's even a fancy `std` algorithm for what
you're trying to do here)
> pulseaudio.h:41
>
> + ~AbstractModel();
> QHash<int, QByteArray> roleNames() const Q_DECL_FINAL;
`override`?
REPOSITORY
R115 Plasma Audio Volume Applet
REVISION DETAIL
https://phabricator.kde.org/D11721
To: drosca, #plasma
Cc: broulik, plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
