broulik added inline comments.

INLINE COMMENTS

> NotificationDelegate.qml:122
>              hasDefaultAction: model.hasDefaultAction
> -            hasConfigureAction: model.hasConfigureAction
> +            hasConfigureAction: model.hasConfigureAction || false
>              urls: {

Can you do that in the place where it sets `hasConfigureAction`, I find it odd 
that this one needs an explicit check but the other one doesn't

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11743

To: kossebau, #plasma
Cc: broulik, plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Reply via email to