davidedmundson added a comment.
cool, seems mostly fine. One minor style comment
INLINE COMMENTS
> wallpaperplugin.cpp:26
> + m_newStuffDialog = new KNS3::DownloadDialog(
> QString::fromLatin1("wallpaperplugin.knsrc") );
> + KNS3::DownloadDialog *strong = m_newStuffDialog.data();
> + strong->setTitle(i18n("Download Wallpaper Plugins"));
You don't need to do this.
QPointer has a custom -> operator
So m_newStuffDialog->setTitle works just fine.
Same for in newStuffFinished
REPOSITORY
R131 Plasma Wallpapers
REVISION DETAIL
https://phabricator.kde.org/D12040
To: Zren, #plasma
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
