bruns added inline comments. INLINE COMMENTS
> AuthDialog.cpp:345 > // neither isEmpty() or isNull() worked (?) > if (actionDescription.description() == "") { > QFont descrFont(action_label->font()); ` == ""` should be identical to .isEmpty(), please recheck > AuthDialog.cpp:349 > action_label->setFont(descrFont); > - action_label->setText(i18n("Not Applicable")); > + action_label->setText(i18n("Not Available")); > } else { According to https://www.freedesktop.org/software/polkit/docs/latest/polkit.8.html#polkit-rules `description` is not optional, so the correct statement is "Missing" > authdetails.ui:26 > <property name="text"> > - <string>Action:</string> > + <string>Action ID:</string> > </property> I think "ID" is sufficient REPOSITORY R121 Policykit (Polkit) KDE Agent REVISION DETAIL https://phabricator.kde.org/D12498 To: sharvey, bruns, ngraham, davidedmundson Cc: davidedmundson, bruns, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart