davidedmundson accepted this revision. davidedmundson added inline comments. This revision is now accepted and ready to land.
INLINE COMMENTS > broulik wrote in models_p.h:26 > Do we need an explicit `Q_DECL_HIDDEN` or something? No. That's only needed for when people do class AbstractModel::Private where AbstractModel is exported REPOSITORY R994 Pulseaudio Qt Bindings BRANCH dptr REVISION DETAIL https://phabricator.kde.org/D12481 To: nicolasfella, drosca, apol, davidedmundson Cc: davidedmundson, broulik, apol, drosca, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart