aacid accepted this revision. aacid added a comment. This revision is now accepted and ready to land.
Ok, then please commit (5,8, 5.12 and then merge 5.12 to master) If you're unsure how to do the commits tell me and i can do it for you. Ideally i'd like a more verbose comment for the "keep stderr open" comment, maybe "keep stderr open so socket doesn't returns us that fd" REPOSITORY R107 KWallet PAM Integration BRANCH cve_bugfix (branched from master) REVISION DETAIL https://phabricator.kde.org/D12702 To: maximilianocuria, #plasma, aacid Cc: asturmlechner, rdieter, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
