mart added a comment.

  +1 for moving the add language button bottom-right

INLINE COMMENTS

> main.qml:66
> +            delegate: Kirigami.BasicListItem {
> +                Layout.fillWidth: true
> +

same consideration for Layout.* in delegates

> main.qml:185
> +
> +            Layout.fillWidth: true
> +            Layout.margins: 0

Layout.* attached properties are useless there, as items in a listview are not 
in a layout.
the correct thing to do here (as documented by qt) is even is not pretty:

width: languagesList.width

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12102

To: hein, #kirigami, mart
Cc: rkflx, aspotashev, davidedmundson, safaalfulaij, abetts, ngraham, 
plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
sebas, apol, mart, hein

Reply via email to