volkov added inline comments.

INLINE COMMENTS

> mart wrote in main.cpp:71
> KWindowSystem::forceActiveWindow should never be used by normal applications, 
> it's reserved for workspaces and won't work on Wayland.
> QWidget::activateWindow should be enough, even if that's not guaranteed to 
> actually raise the window, is more correct.

The documentation of KDBusService recommends to use it:
https://api.kde.org/frameworks/kdbusaddons/html/classKDBusService.html#af0ad38f597aedaf22a30045d0423ed0e
And many applications do it: 
https://lxr.kde.org/search?_filestring=&_string=forceActiveWindow

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D12760

To: volkov, #plasma
Cc: mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

Reply via email to