sharvey marked 7 inline comments as done and 5 inline comments as done. sharvey added inline comments.
INLINE COMMENTS > sharvey wrote in WidgetExplorer.qml:235 > Wellll.... from my (albeit limited) comprehension of `units`, they're all > derived programatically somehow, either from an icon size, a font size, or at > the lowest level, DPI. > > The API page for `Units::gridUnits` reads > > > The fundamental unit of space that should be used for sizes, expressed in > > pixels. > > > > Given the screen has an accurate DPI settings, it corresponds to a width of > > the capital letter M > > So if I understand your question correctly, deriving the row size from a font > size would be redundant. Wouldn't it? Plus, `gridUnit * 2` doesn't //seem// excessively large. There's some whitespace, but I don't think it's overkill. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12855 To: sharvey, ngraham, davidedmundson Cc: abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
