ltoscano added inline comments. INLINE COMMENTS
> romangg wrote in workspaceoptions.cpp:34 > So do we need to change this here, in the CMake file, or can the translation > catalog be renamed (or a new one created) with the name `kcm_workspace` to > make the naming consistent? > > Before in this KCM we used `kcm_workspaceoptions`, `workspaceoptions` and > `kcmworkspaceoptions` at different places. I want to use `kcm_workspace` only > now everywhere. Either you keep the old name, or you change it to kcm5_<name> (which may help avoiding headaches in future). The values in TRANSLATION_DOMAIN and Messages.sh should be consistent. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12936 To: furkantokac, romangg, ngraham, #plasma Cc: ltoscano, yurchor, zzag, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
