ivan requested changes to this revision. ivan added a comment. This revision now requires changes to proceed.
- Would rather have a separate NetworkManager wrapper class implementation (a dummy implementation for when NM is disabled) than this. - Also, instead of a cmake flag, it is more common to find_package and define the flag depending on whether it was found or not. - What about the configuration UI? REPOSITORY R845 Plasma Vault REVISION DETAIL https://phabricator.kde.org/D13255 To: asturmlechner, #plasma, ivan Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
