gladhorn added inline comments. INLINE COMMENTS
> outputconfig.cpp:145 > + connect(scaleDialogButton, &QPushButton::released, [this] { > + QPointer<ScalingConfig> dialog = new ScalingConfig(mOutput, > this); > + dialog->exec(); Why not use QScopedPointer here? REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D12405 To: fvogt, #plasma Cc: gladhorn, mart, hein, ngraham, graesslin, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol