anthonyfieroni added inline comments.
INLINE COMMENTS
> CMakeLists.txt:16
> +
> +#find_package(GIO)
> +find_package(Soup)
Why you comment it when you use it, see below.
> FwupdBackend.cpp:68
> + if (!m_fetching)
> + m_reviews->initialize();
> + populate(QStringLiteral("Releases"));
Indentations should be 4 spaces, if statement goes with { on same line and }
even on one line body.
> FwupdBackend.cpp:85
> + g_strdelimit (tmp, "/", '_');
> + return g_strdup_printf ("org.fwupd.%s.device", tmp);
> +}
It's memory leak.
> FwupdSourcesBackend.cpp:75-77
> + else if(value.toInt() == Qt::Unchecked)
> + {
> + if((value.toInt() == Qt::Checked) )
?
REPOSITORY
R134 Discover Software Store
REVISION DETAIL
https://phabricator.kde.org/D14050
To: abhijeet2096, apol, davidedmundson
Cc: anthonyfieroni, plasma-devel, ragreen, ixoos, Pitel, ZrenBot, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
