zzag added inline comments. INLINE COMMENTS
> osd.cpp:120 > + if (!m_osdActionSelector) { > + const QString &osdPath = > QStandardPaths::locate(QStandardPaths::QStandardPaths::GenericDataLocation, > QStringLiteral("kded_kscreen/qml/OsdSelector.qml")); > + if (osdPath.isEmpty()) { Please delete reference. Compilers can eliminate unnecessary copying, so there is no need to do the lifetime expansion. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14143 To: gladhorn, #plasma Cc: zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart