lepagevalleeemmanuel created this revision.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.
lepagevalleeemmanuel requested review of this revision.

REVISION SUMMARY
  This patch moves the qrc from "raw" to generated using CMake configure file 
and add 4 missing files.
  
  Since some months, a few files were missing from the QRC. It worked fine on 
system where Kirigami is installed (and recent) because it would load them from 
the file system instead of static resources. However it didn't work so well on 
systems where an older version (or no version) are installed.
  
  Because ActionMenuItem is has different versions depending on the Qt version, 
the qrc had to be dynamic. The use of absolute path was also necessary because 
`rcc` could no longer find the files because it uses the relative path from the 
`.qrc` absolute path.

TEST PLAN
  Not much honestly, it works on my system, other might want to double check.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D14673

AFFECTED FILES
  kirigami.qrc
  src/CMakeLists.txt

To: lepagevalleeemmanuel
Cc: plasma-devel, apol, davidedmundson, mart, hein

Reply via email to