ngraham added inline comments.

INLINE COMMENTS

> main.qml:44
> +    // does this need an ellipsis?
> +    readonly property string kcmLabel: i18nc("Open the full display settings 
> module", "Advanced Display Settings...")
> +    readonly property string kcmIconName: "preferences-desktop-display-randr"

Per https://hig.kde.org/style/writing/labels.html#using-ellipses-in-labels, if 
you want this to have ellipses, it has to start with an action verb (e.g. 
"Configure blabla..."). If not, it shouldn't have ellipses, because it's not an 
action, it's for navigation.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D14855

To: broulik, #plasma, #vdg, fischbach, harmathy
Cc: ngraham, mart, gladhorn, abetts, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

Reply via email to