bruns added inline comments. INLINE COMMENTS
> davidedmundson wrote in bookmarksrunner.cpp:65 > do we not also need a disconnect on m_browser? Browser is just an interface class, but the subclasses also derive from QObject and should auto-disconnect, AFAIK. > broulik wrote in bookmarksrunner.cpp:66 > Please provide `this` as context. you mean `this->mbrowser->teardown()`? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D15306 To: bruns, #plasma Cc: davidedmundson, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
