Zren added inline comments.

INLINE COMMENTS

> Zren wrote in main.qml:310
> Hmm. We might want to scale by DPI. While the default 0px will not be 
> affected by DPI, if a Look And Feel sets it to 10px, it would look different 
> for users with 1x DPI and 2x DPI.
> 
> Eg:
> 
>   spacing: plasmoid.configuration.iconsSpacing * units.devicePixelRatio

We probably need to round it too so that the icons start on integer coordinates.

  spacing: Math.round(plasmoid.configuration.iconsSpacing * 
units.devicePixelRatio)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D15862

To: mvourlakos, #plasma, davidedmundson
Cc: Zren, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Reply via email to