davidedmundson added inline comments.
INLINE COMMENTS
> taskgroupingproxymodel.cpp:724
> + } else if (role == AbstractTasksModel::VirtualDesktops) {
> +// FIXME WAYLAND Similar to activities
> +// // Returns the lowest virtual desktop id among all children
> of the
should be mostly a copy/paste right? Anything holding this up?
> taskgroupingproxymodel.cpp:1128
> +
> +
> d->abstractTasksSourceModel->requestVirtualDesktops(mapToSource(TaskGroupingProxyModel::index(row,
> 0)),
> + desktops);
Am I reading this right?
We iterate backwards from N -> 1 because moving the desktop /might/ filter
them.
Then because we might be at 1 child, we will have ungrouped so we change the
root?
I would expect this to not work if a user is sorting by virtual desktops.
Would it work to generate a list of sourceIndexes from all children one loop,
then go over those indexes requesting the desktops?
> tasksmodel.cpp:1026
> {
> - d->filterProxyModel->setVirtualDesktop(virtualDesktop);
> + qDebug() << desktop;
> + d->filterProxyModel->setVirtualDesktop(desktop);
leftover
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D13745
To: hein, mart, mvourlakos, davidedmundson
Cc: anthonyfieroni, zzag, ngraham, abetts, plasma-devel, ragreen, Pitel,
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
