sitter created this revision. sitter added a reviewer: broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision.
REVISION SUMMARY it doesn't have technical downsides but ends up creating urls of the type scheme://@host/path which is technically equal to scheme://host/path, so the excess @ is really just not necessary. simply check if the username is empty and if so do not set a username on the QUrl TEST PLAN - no useless @ - setting up fish connection with and without username still works (without defaults to local username) REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D16275 AFFECTED FILES knetattach/knetattach.cpp To: sitter, broulik Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart