ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks.
This does not actually compile for me against current git master: /home/dev/repos/plasma-framework/src/declarativeimports/core/units.cpp: In static member function ‘static int Units::roundToIconSize(int)’: /home/dev/repos/plasma-framework/src/declarativeimports/core/units.cpp:160:65: error: cannot call member function ‘int Units::devicePixelIconSize(int) const’ without object } else if (size < devicePixelIconSize(KIconLoader::SizeSmall)) { ^ /home/dev/repos/plasma-framework/src/declarativeimports/core/units.cpp:161:58: error: cannot call member function ‘int Units::devicePixelIconSize(int) const’ without object return devicePixelIconSize(KIconLoader::SizeSmall) / 2; ^ /home/dev/repos/plasma-framework/src/declarativeimports/core/units.cpp:162:71: error: cannot call member function ‘int Units::devicePixelIconSize(int) const’ without object } else if (size < devicePixelIconSize(KIconLoader::SizeSmallMedium)) { ^ /home/dev/repos/plasma-framework/src/declarativeimports/core/units.cpp:163:58: error: cannot call member function ‘int Units::devicePixelIconSize(int) const’ without object return devicePixelIconSize(KIconLoader::SizeSmall); ^ /home/dev/repos/plasma-framework/src/declarativeimports/core/units.cpp:164:66: error: cannot call member function ‘int Units::devicePixelIconSize(int) const’ without object } else if (size < devicePixelIconSize(KIconLoader::SizeMedium)) { ^ /home/dev/repos/plasma-framework/src/declarativeimports/core/units.cpp:165:64: error: cannot call member function ‘int Units::devicePixelIconSize(int) const’ without object return devicePixelIconSize(KIconLoader::SizeSmallMedium); ^ /home/dev/repos/plasma-framework/src/declarativeimports/core/units.cpp:166:65: error: cannot call member function ‘int Units::devicePixelIconSize(int) const’ without object } else if (size < devicePixelIconSize(KIconLoader::SizeLarge)) { ^ /home/dev/repos/plasma-framework/src/declarativeimports/core/units.cpp:167:59: error: cannot call member function ‘int Units::devicePixelIconSize(int) const’ without object return devicePixelIconSize(KIconLoader::SizeMedium); ^ /home/dev/repos/plasma-framework/src/declarativeimports/core/units.cpp:168:64: error: cannot call member function ‘int Units::devicePixelIconSize(int) const’ without object } else if (size < devicePixelIconSize(KIconLoader::SizeHuge)) { ^ /home/dev/repos/plasma-framework/src/declarativeimports/core/units.cpp:169:58: error: cannot call member function ‘int Units::devicePixelIconSize(int) const’ without object return devicePixelIconSize(KIconLoader::SizeLarge); ^ src/plasmaquick/CMakeFiles/KF5PlasmaQuick.dir/build.make:374: recipe for target 'src/plasmaquick/CMakeFiles/KF5PlasmaQuick.dir/__/declarativeimports/core/units.cpp.o' failed make[2]: *** [src/plasmaquick/CMakeFiles/KF5PlasmaQuick.dir/__/declarativeimports/core/units.cpp.o] Error 1 CMakeFiles/Makefile2:1782: recipe for target 'src/plasmaquick/CMakeFiles/KF5PlasmaQuick.dir/all' failed make[1]: *** [src/plasmaquick/CMakeFiles/KF5PlasmaQuick.dir/all] Error 2 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D7849 To: pgkos, #plasma, ngraham Cc: kde-frameworks-devel, aspotashev, ngraham, anthonyfieroni, broulik, davidedmundson, plasma-devel, ragreen, Pitel, michaelh, ZrenBot, bruns, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, #frameworks