apol added a comment.

  +1 overall

INLINE COMMENTS

> kquickstyleitem.cpp:193
>          }
> +        int iconWidth = m_properties[QStringLiteral("iconWidth")].toInt();
> +        int iconHeight = m_properties[QStringLiteral("iconHeight")].toInt();

Can we be a bit smarter here? If the size is present maybe we wouldn't have to 
check the pixelMetric.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D16659

To: astippich, #plasma, mart, apol
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Reply via email to