davidedmundson added a comment.

  Given there is some negativity in the feedback I do want to point out that 
it's cool to still upload whatever to the KDE store/wider ecosystem. Not 
everything run in plasma needs to be from plasma; we go to great lengths to 
make sure that's the case.
  
  There's also an alternative that I'd like to suggest:
  According to https://www.kernel.org/doc/Documentation/cgroup-v1/memory.txt 
there's a system called "memory pressure" you can watch for events on a 
specific FD with various levels of out-of-memory-ness. A lot cheaper than 
polling, far more reliable, and following the system's OOM configuration. 
Getting that in at a frameworks level so it can be hooked up to notifications 
in this case, but also garbage collections in UI code could be pretty cool.

INLINE COMMENTS

> freememorynotifier.cpp:55
> +    connect(&timer, &QTimer::timeout, this, 
> &FreeMemoryNotifier::checkFreeMemory);
> +    timer.start(1000 * 5 /* 1 minute */);
> +}

how is that 1 minute?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17217

To: McPain, broulik, #vdg, ngraham
Cc: davidedmundson, graesslin, abetts, ngraham, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

Reply via email to