dfaure added a comment.
Looks good except for the TODO comment. I think the comment that is actually needed is one about why we have a "noninteractive" option and it has no effect whatsoever ;) INLINE COMMENTS > kioclient.cpp:278 > + // interactive used to be the default, but due to a porting error it > broke > + // for compatibility noninteractive is now the default (TODO change > for Plasma 6?) > s_interactive = false; Why would we want to break compatibility yet again? ;-) REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D17652 To: davidedmundson, #plasma, nerdopolist, dfaure Cc: broulik, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
