davidedmundson added a comment.
If we are going to effectively remove it, I would like to see it removed fully. Otherwise we'll get some crufty code that doesn't make sense forever as well as quirky bugs. INLINE COMMENTS > componentchooserbrowser.cpp:69 > + > + if ((m_browserService && m_browserService->storageId() == > service->storageId()) || service->exec() == m_browserExec) { > + browserCombo->setCurrentIndex(browserCombo->count() - 1); m_browserService is initialised after this. It won't set the correct index. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17372 To: ngraham, #plasma, #vdg Cc: dfaure, abetts, davidedmundson, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart