enriquem added a comment.

  >> I see. Maybe do not set it at all if one-time password is not used and let 
NM to set the default value? That way we won't be using a wrong value in case 
this changes in future.
  > 
  > Fair enough. I will update the diff with this. However, judging from the 
current behavior, if we do not set the value, nothing will be added to the 
config file. No harm will be made, though.
  
  Actually, this is not what the gnome applet does. Per 
https://github.com/GNOME/NetworkManager-fortisslvpn/blob/master/properties/nm-fortisslvpn-editor.c
 what they do is set the flags via bit-wise operations. I will update the diff 
with this behaviour
  
  Please, be aware that I cannot compile the code now, so there may be errors. 
I expect your understanding.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D17834

To: enriquem, jgrulich
Cc: plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Reply via email to