asturmlechner added inline comments.

INLINE COMMENTS

> drosca wrote in CMakeLists.txt:46
> This should probably use cache variables:
> 
>   set(USE_GCONF FALSE CACHE STRING "Build with GConf")
>   set(USE_GSETTINGS TRUE CACHE STRING "Build with GSettings")

this still needs to be addressed, anything else though?

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D14147

To: nicolasfella, drosca, davidedmundson
Cc: lbeltrame, evpokp, rikmills, broulik, asturmlechner, plasma-devel, 
sukalyanbanga, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Reply via email to