ngraham added inline comments.

INLINE COMMENTS

> kcm_splashscreen.desktop:2
>  [Desktop Entry]
> -Icon=preferences-system-splash
> +Icon=preferences-system-login
>  Exec=kcmshell5 kcm_splashscreen

I know you're making this change because we don't actually have a 
`preferences-system-splash` icon, but is this really semantically correct? It 
seems like we should actually create that icon, or maybe make 
`preferences-system-login` a symlink to it for now.

Of course that's a frameworks change, so it wouldn't get done in time for the 
Plasma 5.15 release...

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18269

To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Reply via email to