ossi requested changes to this revision.
ossi added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> ptracer.cpp:65
> + bytes += r;
> + else if (r == -1 && !(errno == EINTR))
> + break;
you really could just use != here ... ^^
> ptracer.cpp:78
> + bytes += r;
> + else if (r == -1 && !(errno == EINTR))
> + break;
ditto
> ptracer.cpp:82
> + if (bytes == msize && memcmp(msg, rmsg, msize) == 0)
> + qCInfo(DRKONQI_LOG) << "ptracer set to" << debuggerpid
> << "by debugged process";
> + }
a complementary warning if any of the steps goes wrong would seem appropriate.
> crashtest.cpp:139
>
> - //start drkonqi directly so that drkonqi's output goes to the console
> + //start drkonqi directly by default so that drkonqi's output goes to the
> console
> KCrash::CrashFlags flags = KCrash::AlwaysDirectly;
add comment: this can be disabled to be able to test kcrash's real default
behavior.
> crashtest.cpp:143
> flags |= KCrash::AutoRestart;
> + if (parser.isSet(QStringLiteral("kdeinit")))
> + flags &= ~KCrash::AlwaysDirectly;
move that up, so the AlwaysDirectly stuff is in one block.
REPOSITORY
R871 DrKonqi
REVISION DETAIL
https://phabricator.kde.org/D11235
To: croick, #plasma_workspaces, #frameworks, ossi
Cc: ossi, lepagevalleeemmanuel, maximilianocuria, adridg, plasma-devel,
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
