GB_2 added a comment.

  Looks good!

INLINE COMMENTS

> ToolBoxButton.qml:30
>  
> -    property string text: main.Plasmoid.activityName
> +    property string text: main.Plasmoid.activityName == i18n("Default") ? 
> i18n("Desktop Toolbox") : i18n("Desktop Toolbox - %1 Activity", 
> main.Plasmoid.activityName)
>      property bool isCorner: !buttonMouse.dragging &&

I think we should use this dash "—" instead of "-" for consistency.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  desktop-toolbox-clearer-naming (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18528

To: ngraham, #vdg, #plasma, hein
Cc: GB_2, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Reply via email to