hein added inline comments.

INLINE COMMENTS

> Task.qml:155
>                  } else if (plasmoid.configuration.middleClickAction == 
> TaskManagerApplet.Backend.Close) {
> +                    tasks.taskClosedWithMouseMiddleButton = pid
>                      tasksModel.requestClose(modelIndex());

Getting close, but `pid` is not reliable. It's not available for all tasks 
(e.g. remote X11 clients). You need to use the window id role instead.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arc_taskmanagerclose (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18438

To: thsurrel, #plasma, #vdg, hein
Cc: hein, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Reply via email to