tcanabrava created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. tcanabrava requested review of this revision.
REVISION SUMMARY Move public classes to Internal Structs Make sure we are not accessing something wrong No need to clear on destruction Simplify ::data() method Test only once Simplify iterating over items Don't use java style iterators, they are quite slow. Multipe misuses of a QMap - Don't detach the values - Don't .contains / .value, use find() directly - Cache the resut Remove newlines REPOSITORY R106 KSysguard BRANCH CleanSensorBrowser REVISION DETAIL https://phabricator.kde.org/D18579 AFFECTED FILES gui/SensorBrowser.cpp gui/SensorBrowser.h To: tcanabrava Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart