broulik added inline comments.

INLINE COMMENTS

> Toolbar.qml:116
> +        id: wifiRefreshButton
> +        enabled: false
> +

I would do it declaratively:

  enabled: !coolDownTimer.running

> Toolbar.qml:124
> +
> +        tooltip: i18ndc("plasma-nm", "button tooltip", "Scan for new 
> wireless networks")
> +        iconSource: "view-refresh"

Why does this need an explicit domain?

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D18621

To: vpilo, #vdg, #plasma, jgrulich, ngraham
Cc: broulik, davidedmundson, alexeymin, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

Reply via email to