mart requested changes to this revision. mart added inline comments. This revision now requires changes to proceed.
INLINE COMMENTS > PassiveNotification.qml:65 > + //be working with multiple windows at once > + timer.running = Qt.binding(function() { > + return root.Window.active; this will probably mke the timer always running when the window has focus whether or not there is a notificationshown or not? something like: Connections { target:root.Window onActiveChanged: { if(root.opacity == 1) { timer.restart(); } } } REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D18796 To: ngraham, #kirigami, mart, broulik, apol Cc: plasma-devel, broulik, dkardarakos, apol, davidedmundson, mart, hein