jgrulich added inline comments.

INLINE COMMENTS

> handler.cpp:64
>  
> +namespace {
> +    const int wirelessScanRetryInterval = 2000; // Interval (in ms) between 
> attempts to scan for wifi networks

It doesn't need to be in namespace.

> handler.cpp:444
> +    qCDebug(PLASMA_NM) << "Trying soon a new scan on" << interface;
> +    m_WirelessScanRetryTimer.callOnTimeout([this,interface]() {
> +        m_WirelessScanRetryTimer.disconnect();

This is Qt 5.12 only, Plasma 5.16 is going to depend on it so if you plan to 
you this, you should bump required Qt version.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D18896

To: vpilo, jgrulich, ngraham, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Reply via email to