ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed.
+1 for the fix, but let's also use the opportunity to clean up the code a bit here and correct the improper use of hardcoded font sizes. See inline comments. INLINE COMMENTS > main.qml:73 > > Text { > color: palette.text While we're at it, let's port this to use a Kirigami Heading item instead of a raw Text with hardcoded font sizes. That's gross. > main.qml:83 > } > Text { > + id: versionNumber This should should be a QQC2 Label, and not use hardcoded font sizes. > main.qml:91 > } > Text { > color: palette.text Ditto > main.qml:99 > } > Text { > + id: licenseInfo Ditto > main.qml:106 > } > Text { > color: palette.text Ditto > main.qml:114 > } > Text { > + id: emailAddress ditto REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D19077 To: filipf, #plasma, #vdg, ngraham Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart