filipf planned changes to this revision. filipf added a comment.
Added inline comments for things I'm struggling with. INLINE COMMENTS > main.qml:25 > id: root > - SystemPalette { id: palette; colorGroup: SystemPalette.Active } > - color: palette.base > + frameVisible: true > width: 360 Need to use this because otherwise there is an ugly white rectangle below that QQC2.ScrollView and Kirigami.ScrollablePage can't hide > main.qml:41 > + id: column > + width: 340 > + TODO: how to make the column layout as wide as root, but minus the scrollbars? > main.qml:45 > + id: previewImage > + Layout.maximumWidth: root.width > + Layout.maximumHeight: 210 I want the image to use all of the ColumnLayout's width and then just choose whichever height it can based on its aspect. Can't get that to work. > main.qml:53 > + Kirigami.Heading { > + text: themeName > + Layout.maximumWidth: root.width I want to add an "version" here as well so that it looks like: themeName (version) REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D19077 To: filipf, #plasma, #vdg, ngraham Cc: rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart