ngraham created this revision. ngraham added reviewers: Plasma, Zren. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision.
REVISION SUMMARY The use of a tri-state checkbox for the three possible states (12hr, 24hr, use locale default) is not ideal because it violates the convention regarding what tri-state checkboxes are used for: nested lists where some sub-items can be unselected. This patch replaces it with a combobox that clearly indicates all three states. BUG: 402487 FIXED-IN: 5.16.0 TEST PLAN New UI: F6630383: Combobox.png <https://phabricator.kde.org/F6630383> Tested functionality with `en_US` locale. Check out the clock in the bottom-right corner of the following screenshots: Default state: use locale default: F6630384: Use locale default.png <https://phabricator.kde.org/F6630384> Force 12 hour time: F6630386: Force 12 hour.png <https://phabricator.kde.org/F6630386> Force 24-hour time F6630391: Force 24 hour.png <https://phabricator.kde.org/F6630391> REPOSITORY R120 Plasma Workspace BRANCH replace-tristate-checkbox-with-combobox (branched from master) REVISION DETAIL https://phabricator.kde.org/D19230 AFFECTED FILES applets/digital-clock/package/contents/ui/configAppearance.qml To: ngraham, #plasma, Zren Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
