croick added a subscriber: ossi. croick added a comment.
I dug in the history of KCrash and realized, that closing all the file descriptors was introduced (7bbf112e5e97d40b9a4f9fdd167b064a1019843b <https://phabricator.kde.org/R446:7bbf112e5e97d40b9a4f9fdd167b064a1019843b>) to make the X11 window disappear. Later @ossi added the X11 FD explicitly (7ac326ddb05eec296fdfbebd86d0d1320e579063 <https://phabricator.kde.org/R446:7ac326ddb05eec296fdfbebd86d0d1320e579063>), but kept closing the FDs by default. I think keeping the FDs should be the default. However, the only program I found that is explicitly setting `KCrash::CrashFlag::KeepFDs` is #falkon <https://phabricator.kde.org/tag/falkon/>, the rest seems to be fine without (except me with KDevelop). REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D18245 To: croick, sitter, #kdevelop Cc: ossi, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
